Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type hints to constants #3944

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added type hints to constants #3944

wants to merge 10 commits into from

Conversation

Xenios91
Copy link
Contributor

Constants should be able to have type hints, I added this.

@Xenios91 Xenios91 marked this pull request as ready for review January 26, 2024 02:21
KvanTTT
KvanTTT requested changes Jan 27, 2024
View reviewed changes
vba/vba.g4 Outdated Show resolved Hide resolved
@KvanTTT KvanTTT added example New example of file(s) parsed by grammar-generated parser vba labels Jan 27, 2024
@teverett
Copy link
Member

teverett commented Feb 1, 2024

@Xenios91 thanks!

@teverett teverett requested a review from KvanTTT February 1, 2024 22:48
@Xenios91 @KvanTTT
Update vba/vba.g4
848bfd3 
Co-authored-by: Ivan Kochurkin <[email protected]>
KvanTTT
KvanTTT requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@KvanTTT KvanTTT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix merge conflict with master branch. Unfortunately, I can't merge it with conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KvanTTT KvanTTT KvanTTT requested changes

Assignees
No one assigned
Labels
example New example of file(s) parsed by grammar-generated parser vba
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xenios91 @teverett @KvanTTT