Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Fix #3314 -- base classes out of date, using obsolete antlr4ts fork. #4264

Merged
merged 7 commits into from
Sep 29, 2024

Conversation

kaby76
Copy link
Contributor

@kaby76 kaby76 commented Sep 27, 2024

*** Requires #4253 ***

The TypeScript port used the antlr4ts fork. This PR changes the port to official Antlr4 TypeScript.

I updated the readme to a standard format. I moved the "not working" tests into examples/ and updated the desc.xml.

@kaby76 kaby76 marked this pull request as draft September 27, 2024 10:50
@kaby76 kaby76 marked this pull request as ready for review September 27, 2024 21:20
@kaby76
Copy link
Contributor Author

kaby76 commented Sep 27, 2024

@teverett All set with this change. Thanks!

@teverett
Copy link
Member

@kaby76 thanks

@teverett teverett merged commit 822f23c into antlr:master Sep 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants