scripts/hw_rowhammer.py: Fix incorrect number of ACT

gateware/payload_executor.py: Fix rank selection
scripts/rowhammer.py: Fix bankbits count for DDR5

This commit fixes an incorrect amount of ACT commands, when the payload executor is selected.
By default read_count should define how many read accesses/activations are performed.
They should be split evenly over selected rows.
On the other hand, payload generation was creating `read_count` ACTs to each selected row.
This caused `nrows *  read_Count` ACT to be sent.
From now on payload will have `floor(read_count / nrows) * nrows` ACT commands.

Signed-off-by: Maciej Dudek <[email protected]>

rowhammer_tester/gateware/payload_executor.py

@@ -123,7 +123,7 @@ def __init__(self, instruction, *, rankbits, bankbits, rowbits, colbits):
 
         if rankbits:
             self.dfi_rank = Signal(rankbits)
-            self.comb += self.dfi_bank.eq(self.address[:rankbits]),
+            self.comb += self.dfi_rank.eq(self.address[:rankbits]),
 
 class Encoder:
     """Helper for writing payloads"""

rowhammer_tester/scripts/hw_rowhammer.py

@@ -120,7 +120,7 @@ def run(self, row_pairs, pattern_generator, read_count, row_progress=16, verify_
             for i, row_tuple in enumerate(row_pairs, start=1):
                 s = 'Iter {:{n}} / {:{n}}'.format(i, len(row_pairs), n=len(str(len(row_pairs))))
                 if self.payload_executor:
-                    self.payload_executor_attack(read_count=read_count, row_tuple=row_tuple)
+                    self.payload_executor_attack(read_count=read_count//len(row_tuple), row_tuple=row_tuple)
                 else:
                     if len(row_tuple) & (len(row_tuple) - 1) != 0:
                         print("ERROR: BIST only supports power of 2 rows\n")

rowhammer_tester/scripts/rowhammer.py

@@ -293,8 +293,8 @@ def payload_executor_attack(self, read_count, row_tuple):
             read_count=read_count,
             row_sequence=row_tuple,
             timings=self.settings.timing,
-            bankbits=self.settings.geom.bankbits,
-            bank=self.bank,
+            bankbits=self.settings.geom.bankbits if self.settings.phy.memtype != "DDR5" else self.settings.geom.bankbits + 1,
+            bank=self.bank if self.settings.phy.memtype != "DDR5" else self.bank*2,
             payload_mem_size=self.wb.mems.payload.size,
             refresh=not self.no_refresh,
             sys_clk_freq=sys_clk_freq,