Skip to content

Commit

Permalink
Don't include xls/common/logging/logging.h; it was replaced by absl l…
Browse files Browse the repository at this point in the history
…ogging.

The logging.h and corresponding library are now empty and don't provide
any symbols anymore.

Remove all the includes in sources and reference in BUILD files
as preparation to then delete the xls/common/logging:logging library
in a subsequent change.

Issues google#1318

PiperOrigin-RevId: 618009459
  • Loading branch information
hzeller authored and copybara-github committed Mar 22, 2024
1 parent 8757f28 commit d381e14
Show file tree
Hide file tree
Showing 22 changed files with 0 additions and 42 deletions.
21 changes: 0 additions & 21 deletions xls/noc/config_ng/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ cc_library(
deps = [
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -101,7 +100,6 @@ cc_library(
deps = [
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -124,7 +122,6 @@ cc_library(
":topology_endpoint_options_proto_builder",
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -146,7 +143,6 @@ cc_library(
deps = [
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -167,7 +163,6 @@ cc_library(
deps = [
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -190,7 +185,6 @@ cc_library(
":topology_options_network_config_builder_cc_proto",
":unidirectional_butterfly_options_proto_builder",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -213,7 +207,6 @@ cc_library(
deps = [
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -234,7 +227,6 @@ cc_library(
deps = [
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -255,7 +247,6 @@ cc_library(
deps = [
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -280,7 +271,6 @@ cc_library(
":unidirectional_tree_options_proto_builder",
"@com_google_absl//absl/log:die_if_null",
"@com_google_absl//absl/types:span",
"//xls/common/logging",
],
)

Expand All @@ -304,7 +294,6 @@ cc_library(
":topology_endpoint_options_proto_builder",
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -326,7 +315,6 @@ cc_library(
deps = [
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -349,7 +337,6 @@ cc_library(
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common:proto_adaptor_utils",
"//xls/common/logging",
],
)

Expand All @@ -372,7 +359,6 @@ cc_library(
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common:proto_adaptor_utils",
"//xls/common/logging",
],
)

Expand All @@ -395,7 +381,6 @@ cc_library(
":node_options_proto_builder",
":topology_options_network_config_builder_cc_proto",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -418,7 +403,6 @@ cc_library(
deps = [
"@com_google_absl//absl/container:flat_hash_set",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand All @@ -443,7 +427,6 @@ cc_library(
"@com_google_absl//absl/log:die_if_null",
"@com_google_absl//absl/status",
"//xls/common:iterator_range",
"//xls/common/logging",
"//xls/ir:unwrapping_iterator",
],
)
Expand All @@ -466,7 +449,6 @@ cc_library(
deps = [
":network_component_port",
"@com_google_absl//absl/log:die_if_null",
"//xls/common/logging",
],
)

Expand Down Expand Up @@ -523,7 +505,6 @@ cc_library(
"@com_google_absl//absl/log:check",
"@com_google_absl//absl/status",
"@com_google_absl//absl/types:span",
"//xls/common/logging",
"//xls/common/status:ret_check",
],
)
Expand Down Expand Up @@ -626,7 +607,6 @@ cc_library(
deps = [
"@com_google_absl//absl/log:check",
"@com_google_absl//absl/status:statusor",
"//xls/common/logging",
"//xls/ir:bits",
],
)
Expand Down Expand Up @@ -699,7 +679,6 @@ cc_library(
":dimension_bounds",
"@com_google_absl//absl/container:inlined_vector",
"@com_google_absl//absl/log:check",
"//xls/common/logging",
],
)

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/arbitrary_base_number.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include <vector>

#include "absl/status/statusor.h"
#include "xls/common/logging/logging.h"
#include "xls/ir/bits.h"

namespace xls::noc {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/bidirectional_butterfly_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/bidirectional_tree_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/butterfly_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/butterfly_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/channel_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <string_view>

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"
#include "xls/common/proto_adaptor_utils.h"

namespace xls::noc {
Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/coordinate_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/coordinate_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/custom_topology_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/custom_topology_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/dimension_order_entry_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/dimension_order_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/dimension_order_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {
DimensionOrderOptionsProtoBuilder::DimensionOrderOptionsProtoBuilder(
Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/flattened_multi_dimensional_array.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

#include "absl/container/inlined_vector.h"
#include "absl/log/check.h"
#include "xls/common/logging/logging.h"
#include "xls/noc/config_ng/coordinate.h"
#include "xls/noc/config_ng/dimension_bounds.h"

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/fully_connected_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/fully_connected_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/level_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/level_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/network_component.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include <vector>

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/network_component_port.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/network_component_port.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/network_component_port_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <vector>

#include "absl/log/check.h"
#include "xls/common/logging/logging.h"
#include "xls/common/status/ret_check.h"
#include "xls/noc/config_ng/network_component_port.h"
#include "xls/noc/config_ng/network_connection.h"
Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/network_connection.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/network_connection.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"
#include "xls/noc/config_ng/network_component_port.h"

namespace xls::noc {
Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/node_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include <string_view>

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"
#include "xls/common/proto_adaptor_utils.h"

namespace xls::noc {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/topology_endpoint_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
1 change: 0 additions & 1 deletion xls/noc/config_ng/tree_options_proto_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/tree_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/unidirectional_butterfly_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "xls/noc/config_ng/unidirectional_tree_options_proto_builder.h"

#include "absl/log/die_if_null.h"
#include "xls/common/logging/logging.h"

namespace xls::noc {

Expand Down

0 comments on commit d381e14

Please sign in to comment.