chore(common): Use Box::leak rather than mem::forget
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
clabby
force-pushed
the
cl/new-preimage-key
branch
from
e0b99b7
to
3762a51
Compare
clabby
force-pushed
the
cl/leak-box-native-io
branch
from
71174d0
to
1f047a7
Compare
refcell
approved these changes
May 24, 2024
Uses `Box::leak` to ensure that the files that are constructed from raw file descriptors are kept alive for the static lifetime of the program, rather than `mem::forget`.
clabby
force-pushed
the
cl/leak-box-native-io
branch
from
1f047a7
to
c5c1106
Compare
This was referenced May 26, 2024
Closed
Closed
Closed
This was referenced Jun 11, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Uses
Box::leakto ensure that the files that are constructed from rawfile descriptors are kept alive for the static lifetime of the program,
rather than
mem::forget.