Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(host): Blocking native client program #201

Merged
merged 3 commits into from
Jun 3, 2024
Merged

fix(host): Blocking native client program #201

merged 3 commits into from
Jun 3, 2024

Commits on Jun 3, 2024

  1. feat(preimage): Async client handles 

    Makes the `HintWriterClient` + `PreimageOracleClient` traits
asynchronous to prevent blocking of the host program when executing a
client program natively.

Previously, since the preimage oracle bindings for the client were
entirely synchronous, the loops in `PipeHandle` could cause a deadlock.
Now that oracle IO is asynchronous, the runtime can interrupt a future
when it yields execution (i.e. `tokio::select` works.)

In the client program, synchronous execution is still guaranteed. It can
run async colored functions in a minimal runtime, such as the `block_on`
runtime in `kona_common`. `simple-revm` had to be changed as a part of
this PR, which has an example of this.
    @clabby
    clabby committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d28422e View commit details
    Browse the repository at this point in the history

  2. fix(host): Blocking native client program 

    Improves the asynchronous logic in `kona-host` to handle gracefully
exiting the parallel host and client threads if either throw.
    @clabby
    clabby committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ba64257 View commit details
    Browse the repository at this point in the history

  3. Update bin/host/src/main.rs 

    Co-authored-by: refcell <[email protected]>
    @clabby @refcell
    clabby and refcell authored Jun 3, 2024
    Configuration menu
    Copy the full SHA
    530bc82 View commit details
    Browse the repository at this point in the history