Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(workspace): Removes Primitives #638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(workspace): Removes Primitives #638

wants to merge 1 commit into from

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 6, 2024

Description

Removes kona-primitives, in favor of upstream alloy types.

Metadata

Closes #516

@refcell refcell requested a review from clabby October 6, 2024 14:10
@refcell refcell self-assigned this Oct 6, 2024
@refcell refcell added K-chore Kind: chore A-primitives Area: kona-primitives crate labels Oct 6, 2024
@refcell refcell changed the title feat(workspace): Removes Primitives chore(workspace): Removes Primitives Oct 6, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 6, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
200 1 199 0
View the top 1 failed tests by shortest run time 
kona-providers-alloy blob_provider::tests::test_get_blob_fallback
Stack Traces | 0.013s run time 
thread 'blob_provider::tests::test_get_blob_fallback' panicked at .../providers-alloy/src/blob_provider.rs:736:87:
called `Result::unwrap()` on an `Err` value: Error("invalid type: string \"0\", expected usize", line: 1, column: 264151)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby Awaiting requested review from clabby

At least 1 approving review is required to merge this pull request.

Assignees

@refcell refcell

Labels
A-primitives Area: kona-primitives crate K-chore Kind: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(primitives): Use Alloy Blob Sidecar Type
1 participant
@refcell