feat: first docker container running #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now boot Geth from inside Docker by running the opup command.
"It works on my machine" (but I can't make any reliability remarks yet)
Changes
The main addition is the
create_dockerfile_build_context()
function in the composer crate. It allows us to generate a "build context" for any image we might want to build from scratch. You just need to supply a Dockerfile and any necessary files that are referenced inside it. They are then added to a tarball archive and gzipped, and fed to the nativebuild_image
Docker API.Also now we can pattern match on client enum variants to have separate functions for each of them:
I realize this is bad for client generalization (aka: bring your own client by just touching a TOML) but we're not there yet!