-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional collection size indicator #296
Add optional collection size indicator #296
Conversation
Nice! But is it possible to display numbers outside brackets?
|
cb151fe
to
5cc0b5a
Compare
Sure, done: counts are now in outside object/array. One things I have noticed, previous iteration of my PR failed due to missing package
So, tests seem to be executed with |
5cc0b5a
to
e9b6728
Compare
Renamed to FX_SHOW_SIZE as it already once was: #138 (comment) |
I don't mind adding that, but honestly it rises questions:
What would be the next smallest change to implement to avoid breaking things too much and still add some vallue, in your opinion? |
|
Oh, you did that already... I thought you were suggesting me doing it. Well done! |
This is my attempt to add requested functionality. Few notes:
FX_SHOWSIZES
environment variable to a truthy value(true
,on
,1
,yes
, case does not matter)./* 123 */
-- to avoid confusing with actual values (e.g.[ 123 ]
could be read as array with single numeric element)...
...
with size indicator....
with size indicator (notation like{"name":/* 123 */
would be very confusing).closes #278