Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing.md to clarify installation of Nx and not Turborepo #469

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

mayank1513
Copy link
Contributor

Description

The description says install turbo globally and the command installs nx globally. Since the setup uses nx, I have clarified the Contributing.md to install nx globally

Motivation and Context

For clarity

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: 22e5195

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xflow-bot xflow-bot bot added the PR: unreviewed PR does not have any reviews. label Jun 3, 2024
@xflow-bot
Copy link
Contributor

xflow-bot bot commented Jun 3, 2024

👋 @mayank1513

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@xflow-bot xflow-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2024
@xflow-bot
Copy link
Contributor

xflow-bot bot commented Jun 24, 2024

Hiya!

This PR has gone quiet. Spooky quiet. 👻

We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!

Thanks for being a part of the AntV community! 💪💯

@xflow-bot xflow-bot bot added the stale Issue that may be closed soon due to the original author not responding any more. label Jun 24, 2024
@mayank1513
Copy link
Contributor Author

not-stale

@xflow-bot xflow-bot bot removed the stale Issue that may be closed soon due to the original author not responding any more. label Jun 25, 2024
@NewByVector NewByVector merged commit d402afa into antvis:2.0 Jul 1, 2024
12 checks passed
@xflow-bot xflow-bot bot removed the PR: unreviewed PR does not have any reviews. label Jul 1, 2024
@xflow-bot
Copy link
Contributor

xflow-bot bot commented Jul 1, 2024

👋 @mayank1513

Congrats on merging your first pull request! 🎉🎉🎉

@xflow-bot xflow-bot bot added the PR: merged PR has merged. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged PR has merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants