Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): test error #320

Merged
merged 2 commits into from
Jul 31, 2024
Merged

chore(ci): test error #320

merged 2 commits into from
Jul 31, 2024

Conversation

wangxingkang
Copy link
Contributor

No description provided.

@wangxingkang
Copy link
Contributor Author

@pearmini 看下

@wangxingkang wangxingkang mentioned this pull request Jul 30, 2024
Closed
@wangxingkang
Copy link
Contributor Author

jestjs/jest#14305 prettier v3 有问题，目前采用了降低版本的形式，看是否可以

@wangxingkang
Copy link
Contributor Author

@pearmini 执行 prettier ./src ./tests --check 有问题，可能与降低版本有关，是把相关文件使用 prettier 处理下？

@pearmini
Copy link
Member

@pearmini 执行 prettier ./src ./tests --check 有问题，可能与降低版本有关，是把相关文件使用 prettier 处理下？

嗯嗯，是得这样

@wangxingkang
Copy link
Contributor Author

好的

@wangxingkang
Copy link
Contributor Author

@pearmini 处理好了

pearmini
pearmini approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

优秀！

package.json Show resolved Hide resolved
@pearmini pearmini merged commit 96e2066 into antvis:master Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangxingkang @pearmini