Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved repetition of code #2849

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

kdotmanoj
Copy link
Contributor

@kdotmanoj kdotmanoj commented Aug 14, 2024

Related Issue

Fixes: None

Description

This pull request consolidates the padding properties for the .container class into a single rule. Previously, the .container class had separate rules for padding and padding-inline, which could lead to confusion and potential conflicts. This change aims to clarify and simplify the padding settings.
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): CSS cleanup

Screenshots / videos (if applicable)

Before
Screenshot from 2024-08-14 17-41-31
Screenshot from 2024-08-14 17-41-09

After
Screenshot from 2024-08-14 17-40-45

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 0:13am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for vermillion-sunshine-40461e ready!

Name Link
🔨 Latest commit 3b0b402
🔍 Latest deploy log https://app.netlify.com/sites/vermillion-sunshine-40461e/deploys/66bc9f76abe96300083bdff3
😎 Deploy Preview https://deploy-preview-2849--vermillion-sunshine-40461e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kdotmanoj
Copy link
Contributor Author

@RishabhDhawad can you please review & merge this :)

@RishabhDhawad RishabhDhawad merged commit 9368530 into anuragverma108:main Aug 14, 2024
7 checks passed
@kdotmanoj kdotmanoj deleted the css-modification branch August 14, 2024 19:42
@kdotmanoj kdotmanoj restored the css-modification branch August 14, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants