Addressed some feedback from Brennan

anza-xyz · Oct 9, 2024 · 069adc7 · 069adc7
1 parent 455faf4
commit 069adc7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/core/src/validator.rs b/core/src/validator.rs
@@ -1090,9 +1090,7 @@ impl Validator {
                 };
 
             let rpc_completed_slots_service =
-                if !config.rpc_config.full_api && geyser_plugin_service.is_none() {
-                    None
-                } else {
+                if config.rpc_config.full_api || geyser_plugin_service.is_some() {
                     let (completed_slots_sender, completed_slots_receiver) =
                         bounded(MAX_COMPLETED_SLOTS_IN_CHANNEL);
                     blockstore.add_completed_slots_signal(completed_slots_sender);
@@ -1103,6 +1101,8 @@ impl Validator {
                         slot_status_notifier.clone(),
                         exit.clone(),
                     ))
+                } else {
+                    None
                 };
 
             let optimistically_confirmed_bank_tracker =

diff --git a/geyser-plugin-interface/src/geyser_plugin_interface.rs b/geyser-plugin-interface/src/geyser_plugin_interface.rs
@@ -323,7 +323,7 @@ pub enum SlotStatus {
     /// First Shred Received
     FirstShredReceived,
 
-    /// Completed
+    /// All shreds for the slot have been received.
     Completed,
 }