remove itertools from solana-signer

anza-xyz · Oct 6, 2024 · 4c0cba4 · 4c0cba4
1 parent c7aeb4a
commit 4c0cba4
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/programs/sbf/Cargo.lock b/programs/sbf/Cargo.lock
diff --git a/sdk/signer/Cargo.toml b/sdk/signer/Cargo.toml
@@ -12,7 +12,6 @@ edition = { workspace = true }
 [dependencies]
 bs58 = { workspace = true, features = ["std"], optional = true }
 ed25519-dalek = { workspace = true, optional = true }
-itertools = { workspace = true }
 rand0-7 = { workspace = true, optional = true }
 solana-pubkey = { workspace = true }
 solana-signature = { workspace = true }

diff --git a/sdk/signer/src/lib.rs b/sdk/signer/src/lib.rs
@@ -1,7 +1,6 @@
 //! Abstractions and implementations for transaction signers.
 use {
     core::fmt,
-    itertools::Itertools,
     solana_pubkey::Pubkey,
     solana_signature::Signature,
     solana_transaction_error::TransactionError,
@@ -164,7 +163,17 @@ impl std::fmt::Debug for dyn Signer {
 
 /// Removes duplicate signers while preserving order. O(n²)
 pub fn unique_signers(signers: Vec<&dyn Signer>) -> Vec<&dyn Signer> {
-    signers.into_iter().unique_by(|s| s.pubkey()).collect()
+    let capacity = signers.len();
+    let mut out = Vec::with_capacity(capacity);
+    let mut seen = std::collections::HashSet::with_capacity(capacity);
+    for signer in signers {
+        let pubkey = signer.pubkey();
+        if !seen.contains(&pubkey) {
+            seen.insert(pubkey);
+            out.push(signer);
+        }
+    }
+    out
 }
 
 /// The `EncodableKey` trait defines the interface by which cryptographic keys/keypairs are read,