Skip to content

Commit

Permalink
update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinheavey committed Aug 13, 2024
1 parent 6edf95f commit 53c84ae
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ci/order-crates-for-publishing.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,11 @@ def load_metadata():
return json.loads(subprocess.Popen(
cmd, shell=True, stdout=subprocess.PIPE).communicate()[0])

# Cargo publish if fine with circular dev-dependencies if
# Cargo publish is fine with circular dev-dependencies if
# they are path deps.
# However, cargo still fails if deps are path deps with versions
# (this when you use `workspace = true`): https://github.com/rust-lang/cargo/issues/4242
# This function checks for these good and bad uses of dev dependencies.
def is_path_dev_dep(package, dependency, wrong_path_dev_dependencies):
no_explicit_version = '*'
is_special_cased = False
Expand Down

0 comments on commit 53c84ae

Please sign in to comment.