Simplify {session_,}result_with_timings types #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Apr 30, 2024
| @@ -542,6 +542,7 @@ impl<S: SpawnableScheduler<TH>, TH: TaskHandler> ThreadManager<S, TH> { | |||
| (result, timings): &mut ResultWithTimings, | |||
| executed_task: Box<ExecutedTask>, | |||
| ) { | |||
| timings.accumulate(&executed_task.result_with_timings.1); | |||
There was a problem hiding this comment.
okay, I'm now very selective for piggybacking minor cleanups.... xD
ryoqun
commented
Apr 30, 2024
| result_with_timings | ||
| .take() | ||
| .unwrap_or_else(initialized_result_with_timings), | ||
| .send(std::mem::replace( |
There was a problem hiding this comment.
hint: this is the sole sender.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1126 +/- ##
=======================================
Coverage 82.2% 82.2%
=======================================
Files 880 880
Lines 235623 235617 -6
=======================================
+ Hits 193699 193731 +32
+ Misses 41924 41886 -38 |
ryoqun
commented
May 1, 2024
| ); | ||
| } else { | ||
| unreachable!(); | ||
| match new_task_receiver.recv() { |
There was a problem hiding this comment.
changed to match for later pr..
apfitzge
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After rethinking about simpler unified scheduler impl, it turned out some types are needlessly complex, which were introduced at solana-labs#34676.
Summary of Changes
Simplify them in preparation of chunked finished prs from the wip all-in-one pr: #1122
There should be no functional changes. and changes should be statically proven to be safe by human...