forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package-metadata: Add macro to define program id from Cargo.toml #1806
Open
joncinque
wants to merge
5
commits into
anza-xyz:master
Choose a base branch
from
joncinque:packagemeta
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+133
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
changed the title
package-metadata: Add macro to define program id from Cargo.toml #1483
package-metadata: Add macro to define program id from Cargo.toml
Jun 20, 2024
buffalojoec
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm again, just need the upstream PR to get reviewed.
joncinque
force-pushed
the
packagemeta
branch
from
October 14, 2024 20:16
cda5c02
to
02c366d
Compare
buffalojoec
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!!
all green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is a remake of #1483 but using a new crate instead of adding to
solana_program
.We've added in the preliminary scaffolding in #1464 and #1465, but we still don't have the last bit to declare the program id in Cargo.toml.
Summary of Changes
Add the macro. As part of this, we have a few additions:
Pubkey::from_str_const
As noted in
Pubkey::from_str_const
, it's currently impossible to do a length check, which isn't great. We'll see if the upstream PR get accepted. I can keep this in draft until that goes through. I can also move that to a separate PR.cc @lorisleiva