forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-build-sbf: Use metadata.solana.tools-version
in Cargo.toml
#2914
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a06764a
cargo-build-sbf: Use `solana.tools-version` in Cargo.toml
joncinque a14c10a
Relax leading "v"
joncinque d6f57d7
Add CHANGELOG entry
joncinque 24e9849
Special-case default run
joncinque 73a5ba9
Add tests
joncinque 6422835
ci: Fix parsing platform tools version
joncinque File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
sdk/cargo-build-sbf/tests/crates/package-metadata/Cargo.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
[package] | ||
name = "package-metadata" | ||
version = "2.1.0" | ||
description = "Solana SBF test program with tools version in package metadata" | ||
authors = ["Anza Maintainers <[email protected]>"] | ||
repository = "https://github.com/anza-xyz/agave" | ||
license = "Apache-2.0" | ||
homepage = "https://anza.xyz" | ||
edition = "2021" | ||
publish = false | ||
|
||
[package.metadata.solana] | ||
tools-version = "v1.43" | ||
|
||
[dependencies] | ||
solana-program = { path = "../../../../program", version = "=2.1.0" } | ||
|
||
[lib] | ||
crate-type = ["cdylib"] | ||
|
||
[workspace] |
12 changes: 12 additions & 0 deletions
12
sdk/cargo-build-sbf/tests/crates/package-metadata/src/lib.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
//! Example Rust-based SBF noop program | ||
|
||
use solana_program::{account_info::AccountInfo, entrypoint::ProgramResult, pubkey::Pubkey}; | ||
|
||
solana_program::entrypoint!(process_instruction); | ||
fn process_instruction( | ||
_program_id: &Pubkey, | ||
_accounts: &[AccountInfo], | ||
_instruction_data: &[u8], | ||
) -> ProgramResult { | ||
Ok(()) | ||
} |
21 changes: 21 additions & 0 deletions
21
sdk/cargo-build-sbf/tests/crates/workspace-metadata/Cargo.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
[package] | ||
name = "workspace-metadata" | ||
version = "2.1.0" | ||
description = "Solana SBF test program with tools version in workspace metadata" | ||
authors = ["Anza Maintainers <[email protected]>"] | ||
repository = "https://github.com/anza-xyz/agave" | ||
license = "Apache-2.0" | ||
homepage = "https://anza.xyz" | ||
edition = "2021" | ||
publish = false | ||
|
||
[dependencies] | ||
solana-program = { path = "../../../../program", version = "=2.1.0" } | ||
|
||
[lib] | ||
crate-type = ["cdylib"] | ||
|
||
[workspace] | ||
|
||
[workspace.metadata.solana] | ||
tools-version = "v1.43" |
12 changes: 12 additions & 0 deletions
12
sdk/cargo-build-sbf/tests/crates/workspace-metadata/src/lib.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
//! Example Rust-based SBF noop program | ||
|
||
use solana_program::{account_info::AccountInfo, entrypoint::ProgramResult, pubkey::Pubkey}; | ||
|
||
solana_program::entrypoint!(process_instruction); | ||
fn process_instruction( | ||
_program_id: &Pubkey, | ||
_accounts: &[AccountInfo], | ||
_instruction_data: &[u8], | ||
) -> ProgramResult { | ||
Ok(()) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I was going to ask if there was a precedence between the versions.