bank: add lightweight bank hash cache to reduce bank forks usage #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
force-pushed
the
bank-hash-cache
branch
from
ab827b4
to
8c02f84
Compare
AshwinSekar
commented
Oct 3, 2024
| pub fn new_rw_arc(root_bank: Bank) -> Arc<RwLock<Self>> { | ||
| pub fn new_rw_arc(mut root_bank: Bank) -> Arc<RwLock<Self>> { | ||
| let bank_hash_cache = Arc::new(RwLock::new(BankHashCache::default())); | ||
| root_bank.set_bank_hash_cache(bank_hash_cache.clone()); |
There was a problem hiding this comment.
root_bank is not frozen until after BankForks is created, so this is necessary.
| ) | ||
| .is_some() | ||
| { | ||
| // All ancestors have already been inserted by another fork |
There was a problem hiding this comment.
This is leftover from when BankForks could be initialized with a list of banks.
AshwinSekar
force-pushed
the
bank-hash-cache
branch
3 times, most recently
from
a89baf8
to
807c9aa
Compare
AshwinSekar
force-pushed
the
bank-hash-cache
branch
from
807c9aa
to
81c7cd0
Compare
|
Carl pointed out that this doesn't really save us much, write lock on insertion happens every 400ms at best so this is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An upcoming change needs to access the replayed bank hash of select slots. It is overkill to grab the
bank_forkslock for such scenarios.Summary of Changes
Similar to the
root_bank_cache, split out a cache just for the latestbank_hashof replayed slots. When a slot is dumped, the cache is not updated which should be fine for our usage. This cache is pruned alongsidebank_forksas to keep in sync.Implementation details:
bank_forksbankis inserted intobank_forks, store a reference to the cache in the bank.bankis frozen, write lock the cache and insert the new bank hash.bank_forksand read lock it when they wish to query bank hash without having to read lockbank_forks.