Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionView: read_entry #3063

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Oct 3, 2024

Problem

  • TransactionView design was mainly towards block production but doesn't super easily work with Entry in block validation

Summary of Changes

  • Write a function to a serialized entry into header + TransactionView

Future

Brief description of the approach in block-validation:

  • serialized entry data must be wrapped in an Arc .
  • read header information (this copies, since afaict rust has no way for me to get a nicely aligned Vec)
  • return iterator over Result. each view has a clone of the arc data + the offset that specific transaction starts at
    • this nicely does not force us to allocate a Vec on consuming side
  • in block validation we must check that all results are Ok for the Entry to be considered Ok

Fixes #

@apfitzge apfitzge added the noCI Suppress CI on this Pull Request label Oct 3, 2024
@apfitzge apfitzge self-assigned this Oct 3, 2024
@apfitzge apfitzge changed the title move trailing bytes check TransactionView: read_entry Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noCI Suppress CI on this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant