Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support completed slot status in geyser #3069

Merged

Conversation

lijunwangs
Copy link

@lijunwangs lijunwangs commented Oct 4, 2024

Problem

This is the second part to support more slot status notification type in geyser. Completed.

Summary of Changes

Link SlotStatusNotifier in rpc_completed_slots_service. Moved SlotStatusNotifier interface to solana_rpc.

Tests: tested change with Postgres geyser plugin and confirming the Completed being received.

Fixes #

#2957

Summary of Changes

Fixes #

Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, seems fine. Left a few minor suggestions

core/src/validator.rs Outdated Show resolved Hide resolved
geyser-plugin-interface/src/geyser_plugin_interface.rs Outdated Show resolved Hide resolved
rpc/src/slot_status_notifier.rs Show resolved Hide resolved
Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lijunwangs lijunwangs merged commit 07faf4a into anza-xyz:master Oct 9, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants