-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix accounts index startup stat and add two new stats for dups #3112
fix accounts index startup stat and add two new stats for dups #3112
Conversation
efa7ebb
to
ca33900
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code looks good. Some nits and requests to rename datapoints, since they are notoriously hard to change later.
accounts-db/src/accounts_db.rs
Outdated
pub total_num_unique_duplicate_keys: u64, | ||
pub accounts_duplicates_num: u64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda wish this was in a separate PR. So one PR for fixing the existing stats, and a second PR for adding the new stats.
83118db
to
724380f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think this is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem
"total_item, max_bin_size, min_bin_size" actually represent the index items stored inside in-memory cache. Rename them to make it explicit that they are stats for in-memory index.
Add a stats to count how many dups (accounts_duplicates_num) and total_num_unique_duplicate_keys encountered during create account index at startup.
Summary of Changes
Fixes #