Scheduler: Improve TTL #3161
Open
Scheduler: Improve TTL #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
reviewed
Oct 14, 2024
| @@ -81,12 +81,14 @@ impl Accounts { | |||
| } | |||
| } | |||
|
|
|||
| /// Return loaded addresses and the deactivation slot. | |||
| /// If no tables are de-activating, the deactivation slot is `u64::MAX`. | |||
There was a problem hiding this comment.
nit: this function only looks up addresses for one ALT
Suggested change
| /// If no tables are de-activating, the deactivation slot is `u64::MAX`. | |
| /// If the table hasn't been deactivated, the deactivation slot is `u64::MAX`. |
| deactivation_slot: Slot, | ||
| current_slot: Slot, | ||
| ) -> MaxAge { | ||
| let alt_min_expire_slot = estimate_last_valid_slot(deactivation_slot.min(current_slot)); |
There was a problem hiding this comment.
Technically this should be current_slot + 1 I think because we know that the ALT didn't get deactivated in the current_slot
| } | ||
| } | ||
|
|
||
| impl Bank { | ||
| /// Load addresses from an iterator of `SVMMessageAddressTableLookup`. | ||
| /// Load addresses from an iterator of `SVMMessageAddressTableLookup`, | ||
| /// additionally returning the deactivation slot |
There was a problem hiding this comment.
Suggested change
| /// additionally returning the deactivation slot | |
| /// additionally returning the minimum deactivation slot across all referenced ALTs |
jstarry
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #