Refactor default Mobile Wallet Adapter button UI #1005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor MWA option in Modal UI
This PR proposes refactoring how the Mobile Wallet Adapter option is presented in the default
WalletModal
UI. Very open and looking forward to feedback and discussion.Rationale
The MWA option is an important action on mobile, one which maximizes wallet choice, since it will allow selection of any user-installed wallets which support the agnostic MWA protocol.
This change aims to provide better context clues to the user around its usage. It replaces the current icon and text “Mobile wallet adapter”, which is not self-explanatory for users not familiar with what that means. The new wording is more descriptive and helps users understand the connection with the installed wallet apps on their phone.
Changes
In
WalletModal
, detect themobileWalletAdapter
and, if present, render:On your phone:
headerUse an installed wallet
button below headerOther wallets:
headerNext
If needed, we can additionally create a similar change in the UI for
ant-design
andmaterial-ui
.Testing
Tested on a local build with the example app across these different test cases, making sure to test that non-MWA modal's are unaffected.