(typing) Allow readonly array of wallets for WalletProvider #1015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mine and some other codebases, immutability goes by default.
The adapter doesn't like it, so the type like
const wallets: readonly [PhantomWalletAdapter, SolflareWalletAdapter]
won't work:I have to either cast or re-construct
<WalletProvider wallets={[...wallets]}/>
, which is undesirable.This PR allows
readonly
arrays aswallets
prop, as well as keeps mutable arrays backwards-compatible.