Add Mute command

[catumin]

Resolves #243.

Add the ability to immediately set volume to 0% as requested in #243. I bound it to _ since "Shift + -" made sense to me, as it's basically super volume decrease.

[aome510]

Hi @BKasin, thanks for the PR. Ideally, mute should be a toggle command. Can you update the PR to support that?

[catumin]

@aome510 I agree that that would be preferable, but am not sure how to best implement it.

[aome510]

@aome510 I agree that that would be preferable, but am not sure how to best implement it.

Yeah, it's kinda tricky. One way is to add a new field called MuteState: Option<u32> in

spotify-player/spotify_player/src/state/player.rs

Lines 5 to 15 in bc605a7

	pub struct PlayerState {
	pub devices: Vec<Device>,
	pub playback: Option<rspotify_model::CurrentPlaybackContext>,
	pub playback_last_updated_time: Option<std::time::Instant>,
	/// a buffered state to speedup the feedback of playback metadata update to user
	// Related issue: https://github.com/aome510/spotify-player/issues/109
	pub buffered_playback: Option<SimplifiedPlayback>,
	pub queue: Option<rspotify_model::CurrentUserQueue>,
	}

, which is None is not mute and Some(previous_volume_percent) if is mute. Handling "mute toggle" command will involve updating that state and sending a PlayerRequest::Volume request.

[catumin]

Thank you for the guidance, I definitely was over-complicating it mentally.

[aome510]

LGTM! Thanks.

It would be nice to also have UI for the mute functionality. Can you change

spotify-player/spotify_player/src/ui/playback.rs

Lines 182 to 188 in 05fbda6

	format!(
	"repeat: {} | shuffle: {} | volume: {}% | device: {}",
	<&'static str>::from(playback.repeat_state),
	playback.shuffle_state,
	playback.volume.unwrap_or_default(),
	playback.device_name,
	),

as well?

Maybe displayvolume: old_percent% (muted) if muted or volume: current_percent% if not.

[catumin]

Yeah, a little later today when I get home I'll do that.

[aome510]

Thanks @BKasin, after testing the change locally, I thought that the command logic could be simplified a bit more and we also need to handle the case when user increases/decreases the volume on mute. I updated the PR according to implement the above changes in a3930ac

[catumin]

Ah, yeah that is definitely a lot better. Thank you!