Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proposal for #561 #562

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix proposal for #561 #562

merged 2 commits into from
Oct 14, 2024

Conversation

DJ-pH3luy
Copy link
Contributor

@DJ-pH3luy DJ-pH3luy commented Sep 7, 2024 •
edited by aome510
Loading

Fix conditional compilation that it works with notify enabled and steaming disabled. See #561 for details.

Fixes #561

@DJ-pH3luy DJ-pH3luy mentioned this pull request Sep 7, 2024
Closed
@DJ-pH3luy DJ-pH3luy marked this pull request as ready for review September 8, 2024 00:17
aome510
aome510 approved these changes Sep 22, 2024
View reviewed changes
Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@aome510 aome510 merged commit 0be20c0 into aome510:master Oct 14, 2024
3 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aome510 aome510 aome510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The 'notify' feature requires the 'streaming' feature, otherwise it won't compile
2 participants
@DJ-pH3luy @aome510