removes unused zookeeper nodes in upgrade #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-turner
commented
Jun 27, 2024
|
|
||
| // clean up nodes no longer in use | ||
| zrw.recursiveDelete(zooRoot + ZTRACERS, ZooUtil.NodeMissingPolicy.SKIP); | ||
| zrw.recursiveDelete(zooRoot + ZCONF_LEGACY, ZooUtil.NodeMissingPolicy.SKIP); |
There was a problem hiding this comment.
@ctubbsii @EdColeman is it ok to remove this zookeeper node in the 3.1 upgrade?
There was a problem hiding this comment.
I looked into this a bit and do not think there is anything to actually remove in zookeeper. Looking at ConfigPropertyUpgrader in 2.1 ZCONF_LEGACY is only used for table and namespace config AND the upgrade sets a boolean to remove those.
There was a problem hiding this comment.
Going to update this PR to only remove the constant.
|
For #4587 was reviewing what is outstanding for the elasticity upgrade I noticed these two unused zookeeper constants. Seems they can be removed from ZK if they exist in the 3.1 upgrade. |
dlmarion
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.