Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [AMQ-9359] Jetty-12 conversion #1344

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mattrpav
Copy link
Contributor

@mattrpav mattrpav commented Nov 4, 2024

TODO:

  • Compile fixes
  • Fix web-demo compile issue with InputStreamContentProvider
  • Fix/Refactor JspConfigurer to use Handler.Sequence
  • Unit test compile fixes
  • activemq-http WebSocket client tests failing
  • Refactor all jetty.xml's to support updated class package locations

@mattrpav mattrpav self-assigned this Nov 4, 2024
@mattrpav mattrpav changed the title WIP [AMQ-9359] Jetty-12 conversion WIP: [AMQ-9359] Jetty-12 conversion Nov 4, 2024
@jbonofre
Copy link
Member

jbonofre commented Nov 5, 2024

I'm already working on this for 6.2./6.3.x.

@mattrpav mattrpav force-pushed the AMQ-9359 branch 2 times, most recently from 93cd60b to 1c0c19c Compare December 2, 2024 17:49
@cshannon
Copy link
Contributor

cshannon commented Dec 5, 2024

Is there any reason not to bump to Java EE 10? Jetty 12.x can run multiple EE versions simultaneously so there's not really a reason to not just go to Servlet 6.0 and Jakarta EE 10 that I can think of. A user that depends on embedded Jetty and AMQ wants to use EE9 for other servlets could still include those jars and be compatible.

@mattrpav
Copy link
Contributor Author

mattrpav commented Dec 5, 2024

I think EE10 makes more sense. However, if we jump straight to EE10, I think we’d need to rev to 7.x.

Staying with EE9 would allow us to get to Jetty 12 in 6.x minor release

@cshannon
Copy link
Contributor

cshannon commented Dec 5, 2024

I think EE10 makes more sense. However, if we jump straight to EE10, I think we’d need to rev to 7.x.

Staying with EE9 would allow us to get to Jetty 12 in 6.x minor release

Looking at it in more detail and reading https://jetty.org/docs/jetty/12/operations-guide/deploy/index.html , I don't think it's compatible after all for EE9 and EE10 when embedded.

EE10 removes some stuff from the API and i took a look at the Jetty 12 download and they actually package all 3 versions of both the API and modules separately (EE8, EE9, EE10) and each war file is isolated for deployment so you can run independently. This of course does not work for something embedded.

So we can probably stick with EE9 until 7.x. I guess if someone wants to use EE10 and with an embedded version of AMQ they could probably still do so as long as they were not using anything that relied on the EE9 stuff (any of the AMQ websockets or servlets, etc) and they would have to exclude the EE9 transitive dependencies from AMQ

@mattrpav
Copy link
Contributor Author

So we can probably stick with EE9 until 7.x. I guess if someone wants to use EE10 and with an embedded version of AMQ they could probably still do so as long as they were not using anything that relied on the EE9 stuff (any of the AMQ websockets or servlets, etc) and they would have to exclude the EE9 transitive dependencies from AMQ

If users embed, they should be able to do EE10 runtime by excluding activemq-http and activemq-web-* modules. I believe the other EE specs in use are forward compatible b/w EE9 and EE10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants