This is an initial version of AGE for PG12.

Co-authored-by: Alex Kwak <[email protected]>
Co-authored-by: Ibrar Ahmad <[email protected]>
Co-authored-by: Josh Innis <[email protected]>
Co-authored-by: John Gemignani <[email protected]>

This is a patch to remove the word incubate from AGE for PG12

Updated the README and RELEASE files.

Co-authored-by: Ibrar Ahmed <“[email protected]”>

Added the ability to pass parameters to the cypher() function via
a function called age_prepare_cypher().

This extra function is necessary because the cypher() function itself
isn't actually executed - it is instead transformed and replaced. This
means that it needs to have its input parameters resolved prior to
that transform. However, parameters aren't resolved until the
execution phase. So, another command to resolve them needs to run
prior to the cypher() function call.

This mainly impacts the drivers, which will need to be updated.

Additionally, modified the golang driver as an example of this new
usage.

Added regression tests.

Modified the python driver to pass parameters to the cypher() function
via age_prepare_cypher()

Modified README for the python driver

Temporary update to show diffs.

Temporary change to view regression errors.

Temporary installcheck test

Temporary installcheck for debugging

On regression test failure, dump the failure to the log.

Fixed compare_agtype_scalar_values returned result. It used a
function, varstr_cmp, that wasn't guaranteed to return 1, 0, or -1.
It was only guaranteed to return >0, 0, or <0. This caused some
builds to fail during the regression tests, as 1, 0, or -1 were
expected.

This change will implement running of the go driver unit tests
upon every pull commit made to the `drivers/golang` code.

It uses the `paths` directive to ensure the github action workflow
only runs when the go driver code is changed.

The docker-compose file is required to instaniate a postgres
instance, needed for unit testing.

* Update to go version 1.19, as 1.16 is EOL

The current version of the driver is 1.16 which went EOL Feb 2021

This upgrades to 1.19 and also configures CI to retrospectively
test back to 1.18 (1.17 is EOL). This will give test coverage
for all actively supported go versions.

* Also update readme go version

* Fixed a bug where python driver throws error when build from source

* Moved required packages to requirements.txt

* Update Readme

Rearranged instructions and added instructions to install from requirements.txt

* Fixed a typo in exceptions.py file

Fixed a typo 'SqlExcution' on line 62 in exceptions.py file

    modified:   Makefile
    modified:   README.md
    modified:   RELEASE
    renamed:    age--1.1.0.sql -> age--1.1.1.sql
    modified:   age.control

    modified:   NOTICE
    modified:   RELEASE
    new file:   age--1.1.0--1.1.1.sql

added PG12 badge

Queries can now call functions using the form CALL ... YIELD.

CALL ... YIELD can be used in some of the following forms:

    Individual:
    CALL
    CALL YIELD
    CALL YIELD WHERE UPDATE/RETURN

    Subqueries:
    READING_CLAUSE CALL YIELD UPDATE/RETURN
    CALL YIELD READING_CLAUSE UPDATE/RETURN

In the future, CALL YIELD support for record returning functions and
multiple variable output functions can be added.

Known Issue with WHERE clause where a WHERE in a MATCH + CALL subquery
does not filter results is known.

Co-authored-by: Dehowe Feng <[email protected]>

Conflicts:
	README.md

Co-authored-by: John Gemignani <[email protected]>

Typo fix where an if statement check was causing a logic error that
caused the where statement to be ignored.

Regression tests added to address this and thoroughly check WHERE
clauses as well.

Co-authored by: John Gemignani <[email protected]>

Fixed the EXPLAIN command to allow for nested cypher commands within
more complex SQL queries.

Fixed the delete_global_graphs function. It was not keeping track of
the previous graph global context pointer.

This was causing a memory leak for multiple graph contexts if
individual graphs were deleted.

Updated the behavior of invalid labels to return NULL rather than
throw an error.

Added additional regression tests as well.

Edited the details available in https://age.apache.org/contribution/how

Added license header to the following 3 files -

   regress/sql/age_global_graph.sql
   regress/sql/age_load.sql
   regress/sql/index.sql

Adjusted regression tests for these 3.

* Fix null pointer on name compare

* typo in name of test script

* additional regression tests and style fixes

Fixed a Travis CI warning message that was overlooked -

warning: ISO C90 forbids mixed declarations and code

Fixed Travis CI warning message -

warning: unused variable ‘stack’

* Modified age_global_graph regression tests

Add files via upload

Add files via upload

Delete age_global_graph.out

Delete age_global_graph.sql

Add files via upload

Add files via upload

* Update age_global_graph.out

* Update age_global_graph.sql

* Update age_global_graph.out

* Update age_global_graph.out

* Update age_global_graph.sql

* added readme for age-jdbc-driver

…radians from STABLE to IMMUTABLE (apache#412)

Reasons:
- These math functions will not scan/lookup database
- They simply take the input (int, float or numeric), applies operation on it and returns the result
- They cannot modify database
- They are guaranteed to return the same results given the same arguments forever

…che#402)

Generally reasons for changing signature of these functions are:
1.These functions do not need to perform database lookup.
2.These functions neither perform database modification.
3.These functions are guaranteed to return the same constant results given the same argument.

…rom STABLE TO IMMUTABLE (apache#404)

* Modified the Volatility Category of functions age_asin and age_acos from STABLE to IMMUTABLE

* Corrected the Volatility Category of functions age_asin and age_acos from STABLE TO IMMUTABLE

Co-authored-by: RC-adaptive <[email protected]>

Co-authored-by: Matheus Matsumoto <[email protected]>

…MUTABLE (apache#405)

* Changed some function signatures to IMMUTABLE

Changed age_id(agtype), age_start_id(agtype) and age_end_id(agtype) from STABLE to IMMUTABLE.

* Revert "Changed some function signatures to IMMUTABLE"

This reverts commit 92ac40d.

* Changed age_id signature to IMMUTABLE

* Function signature was changed from STABLE to IMMUTABLE;
* Function receives a vertex or edge container (or null), and analyze its contents to return the "id" stored in said container;
* As it acts only on its arguments, it will always return the same result, given the same arguments, even across multiple SQL statements, being classified as IMMUTABLE function.

* Changed age_start_id signature to IMMUTABLE

* Function signature was changed from STABLE to IMMUTABLE;
* Function receives an edge container (or null), and analyze its contents to return the "start_id" stored in said container;
* As it acts only on its arguments, it will always return the same result, given the same arguments, even across multiple SQL statements, being classified as IMMUTABLE function.

* Changed age_end_id signature to IMMUTABLE

* Function signature was changed from STABLE to IMMUTABLE;
* Function receives an edge container (or null), and analyze its contents to return the "end_id" stored in said container;
* As it acts only on its arguments, it will always return the same result, given the same arguments, even across multiple SQL statements, being classified as IMMUTABLE function.

* Changed volatility categories of functions from STABLE to IMMUTABLE
* As their result depends upon their input arguments only
* Both are guaranteed to return the same result given the same arguments forever
* They fulfill the requirements to be IMMUTABLE functions

…IMMUTABLE from STABLE (apache#408)

…#409)

* changing function definations of age_rtrim,ltrim,trim from stable to
immutable

* Changed volatility category of functions age_ltrim, age_rtrim, age_trim
from STABLE to IMMUTABLE

Reasons:
- These functions will not scan/lookup database
- They simply take the input (String), applies operation on it and returns the result
- They cannot modify database
- They are guaranteed to return the same results given the same arguments forever

… Stable to Immutable (apache#415)

…stable to immutable (apache#416)

* Fix comment
- IS_A_AGTYPE_SCALAR() checks that type is between AGTV_NULL and AGTV_ARRAY instead of AGTV_BOOL.

* Fix function signatures

- The functions age_length takes a set(path) of nodes(vertices and edges) as
  an argument and computes the length of path.This function does not
  modify database and is guaranteed to return same result given the same
  arguments forever.
- The function age_toboolean just converts bool values in other data types
  passed as an argument to agtype. This function is also guaranteed to return
  same result given the same arguments forever.
- The function age_tofloat also just converts float value in other data types
  passed as an argument to agtype. This function is also guaranteed to return
  same result given the same arguments forever.

All these functions only performs operations on the arguments provided. These
functions don't depend on table data at all.

… to IMMUTABLE (apache#420)

…TABLE to IMMUTABLE (apache#425)

-age_log10, age_e,age_exp function VOLATILITY changed from STABLE to IMMUTABLE
-No database lookup or external configuration required for these functions
-IMMUTABLE class allows the optimizer to build an index for faster processing

… to IMMUTABLE (apache#424)

…ng(),age_size() (apache#434)

…#391)

Whenever a node or an edge within a WHERE clause uses a Var type
expr retrieved from a different cypher parsestate, the Var->varlevelsup
is adjusted.

* create complete graph function

* fix get_label_name

* add regression tests

Changes related to PG12

* heap_open -> table_open
* heap_close -> table_close
* change oid to uint32 wherever required
* change function return type to void from Oid wherever required

Co-authored-by: Utkarsh Kansal <[email protected]>

* add name validation for graphs and labels

* update test script to use valid graph name
Conflicts:
	regress/expected/catalog.out
	regress/sql/catalog.sql

Co-authored-by: John Gemignani <[email protected]>

Conflicts:
	README.md
	drivers/python/age/exceptions.py
	src/backend/executor/cypher_merge.c

Co-authored-by: John Gemignani <[email protected]>

For example, 'SET v = {..}' will remove all properties of
v and set the provided map as its properties.

This patch is credited to deem0n (Dmitriy Dorofeev). Many thanks!

Added the ag_graph and ag_label tables to the pg_dump output.

Co-authored-by: John Gemignani <[email protected]>

* Added comments for create_graph function

-age_exists, which is the executor for exists(property) function, was making up to 3 redundant memory accesses.
-exists(property) predicate function only serves to check if a property exists or not.
-In Cypher, if a property is assigned the value of NULL, this is considered the same as the property not existing at all. Thus the function calls to get the value type is not needed as the check for the null argument itself filters out all NULL inputs. If a property passes this check, it implies existence.

Additional changes:
Null properties are removed from cypher maps in certain cases.
A new property `cypher_map.keep_null` is added. It is set while
transforming CREATE, MATCH and SET clause. Based on its value,
transform_cypher_map tells executor whether to keep the null
properties in maps that appear in the mentioned clauses.

Cases of null removal:
  - For CREATE and SET with equal operator, nulls are removed.

  - For MATCH, nulls are not removed.

  - For SET with plus-equal operator, nulls are kept during
  transformation, but removed after execution.

  - For any other cases, nulls are removed by default.

Co-authored by: John Gemignani <[email protected]>

- This CI workflow will run python driver unit tests and ensure that any
  PR/commit that modifies files under age/drivers/python is passing the tests.
- Moved docker-compose.yaml file in age/drivers/golang to age/drivers,because
  this is required to instaniate a postgres instance, needed for unit testing.
- Modified host address of connection params to localhost in 'test_age_py.py'
  to connect to postgres instance running in docker container.
Conflicts:
	drivers/python/test_age_py.py

Co-authored-by: John Gemignani <[email protected]>

Updated developer mailing list email
Conflicts:
	README.md

Co-authored-by: John Gemignani <[email protected]>

Added user mailing list subscription

Added different video tutorials in it which will help in installation of Apache Age on Windows and MacOS.

- Updated the existing installcheck.yaml
- Removed .travis.yaml file

- Removed path directive
- Changed trigger branch to PG12
- Changed TEST_USER to postgres as it is required to connect to docker
  instance

- Removed path directive
- Changed trigger branch to PG12

Updated overall readme starting from What is Apache AGE.

* Updated Readme for drivers folder and added important links related to
Apache-AGE project which were included in other readme files.

* Updated NodeJS driver readme and added important links of Apache-AGE
project as included in other readme files.

Found async function without any await expressions in NodeJS Driver. Async keyword is used in Asynchronous programming and for the functions that wait for some responses. These functions dont need to be Asynchronous.

* Added function to create a Barbell Graph

* Created auxiliary function to get_next_val_internal;
* Currently creates a bridge of no vertexes between graphs,
will be implemented next.

* Added signature to age_create_barbell_graph

* Moved bracket to next line to macth code standards

* Fixed patterns to match code standards

* moved PG_FUNCTION_INFO_V1(age_create_barbell_graph) next to
  age_create_barbell_graph function;
* added brackets to if/else conditions if just one line;
* moved get_nextval_internal auxiliary function to the beggining of
  the file.

Conflicts:
	src/backend/utils/graph_generation.c

Co-authored-by: John Gemignani <[email protected]>

Conflicts:
	drivers/python/setup.py

Co-authored-by: John Gemignani <[email protected]>

* Fix WITH ignoring WHERE clause

- When transforming WITH clause into return clause, WHERE was getting
  ignored because that case wasn't handled in tranform_cypher_clause_with_where.
- Had to revert to the previous function header of tranform_cypher_clause_with_where
  which had a explicit parameter of where node, because after tranforming cypher_with
  into cypher_return, the wrapper clause now has cypher_return and the where node of
  cypher_with was lost.

* Fix WITH clause segmentation fault

- When transforming columnrefs in WITH clause, it should only check
  referenced Columns in its parsestate or parent parsestate.

- If only expr_kind is WHERE, try to find the columnRef as a transform_entity
  and extract the expr. This will happen in case of (MATCH/WHERE).

* Add regression tests for cypher_with

- Added isEmpty() predicate function to check if a List, map or string is
  empty.

- Added regression tests for isEmpty() function.

Co-authored-by: John Gemignani <[email protected]>

* Fixed bug where the system was crashing
when graph_name was passed as NULL.

* added checks for possible NULL arguments before
calling create_complete_graph.

* Added regress tests for Barbell graph generation

Conflicts:
	src/backend/utils/graph_generation.c

Co-authored-by: John Gemignani <[email protected]>

Fixed issue apache#718 which was due to a lack of input checks for an
edge case and added regression tests.

Addition of the driver parameter patch caused 2 additional edge
cases that needed to be checked -

    SELECT * FROM cypher() AS (result agtype);
    SELECT * FROM cypher(NULL) AS (result agtype);

…pache#721)

- Updated assert to pass EXPR_KIND_SELECT_TARGET.
- Added regression tests.

- Used a small dataset for regression tests.

…pache#734)

- A vertex and  an edge cannot have the same label within the same
  graph, so added a check for that.

- insert_simple_vertex() and insert_simple_edge() functions were not
  checking for the kind of label. Since a vertex cannot be
  inserted into a label relation of edge and vice versa, this was
  causing the server termination. Added a check for that.

- Added regression tests.

Conflicts:
	src/backend/utils/graph_generation.c
	src/include/catalog/ag_label.h

Co-authored-by: John Gemignani <[email protected]>

Added logic to prevent match from following optional match. This
syntax is considered invalid, add logic to throw an error when
this happens.

Also added regression tests to test this logic.

…CH clauses(apache#701) (apache#747)

Fixed an issue where an already resolved variable, when used for
a property constraint in a second MATCH clause, errored out.
See apache#701 and apache#724  for more details. This is part of a series of
PRs done to refactor MATCH clause behavior.

This also fixed a regression test that was erroring out, but was
overlooked.

Adjusted and added additional regression tests.

Co-authored-by: Dehowe Feng <[email protected]>

…che#751)

Fixed an issue where an already resolved variable, when used for
a property constraint, errored out. See apache#724 for more details.

This is the second part of the fix for the match property constraint
bug regarding variable reuse. The prior fix addressed clause-to-clause,
this fix addresses within a clause.

Adjusted and added additional regression tests.

Co-authored-by: Dehowe Feng <[email protected]>

Fixed a segmentation fault edge case regarding invalid labels
being used in a repeated variable.

- Replaced estate->es_output_cid with getCurrentCommandId(true) in
  update_entity_tuple to use the correct CommandId for error checks.

- Added regression tests.

- Added regression tests for unwind.

* Implement CI test for jdbc driver

- Modify jdbc driver to pull correct AGE image from docker hub.
- Also added logger to display the result of tests i.e. passing,
  failing etc.

* Implement CI test for nodejs driver

- Modified connection params to connect with running docker instance.
- Fixed failing tests by modifying the expected outcomes.
- Include asf header as key/value to avoid EJSONPARSE error.
  "//" key will never be used by npm for any purpose,
  and is reserved for comments.

* Update docker-compose to pull age image from corresponding pg version tag

- Removed external links from readme.
- Updated version to 1.0.0

    modified:   Makefile
    modified:   README.md
    modified:   RELEASE
    renamed:    age--1.1.1.sql -> age--1.3.0.sql
    modified:   age.control

Corrected an entry in the RELEASE notes for release.