Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to the readme.md file i.e. Aligned logo and modified titles #976

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

RahimullahShaheen
Copy link
Contributor

In the image below you can notice that the logo is not aligned with the text which i have fixed.
mistake1
Also i modified some titles which needed to be modified.

Copy link
Member

@dehowef dehowef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I think "Install Via" sounds better than "Install From" or "Installation Via." Can you change that?

@dehowef
Copy link
Member

dehowef commented Jun 16, 2023

@RahimullahShaheen can you squash the commits into one

@RahimullahShaheen
Copy link
Contributor Author

@dehowef I have squashed the commits.

@dehowef
Copy link
Member

dehowef commented Jun 16, 2023

@RahimullahShaheen can you fix the typos in your commit as well. Thanks~

@RahimullahShaheen RahimullahShaheen changed the title Made changes to the readme file i.e. Aligned logo and modified titiles Made changes to the readme.md file i.e. Aligned logo and modified titles Jun 17, 2023
@RahimullahShaheen
Copy link
Contributor Author

@dehowef i have rectified the errors.

@dehowef dehowef merged commit 1c29317 into apache:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants