Fix MERGE variable reuse #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the MERGE clause to allow for correct variable reuse in both the transform and execution phase. Fixed an incorrect usage in MATCH where a variable was compared with pg_strcasecmp instead of strcmp. Refactored some of the code using the volatile wrapper. Verified and corrected old regression tests that were in error. Added regression tests.
jrgemignani
requested review from
MuhammadTahaNaveed,
dehowef,
muhammadshoaib and
rafsun42
MuhammadTahaNaveed
approved these changes
Jun 19, 2023
|
Looks good to me. |
rafsun42
approved these changes
Jun 19, 2023
dehowef
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the MERGE clause to allow for correct variable reuse in both the transform and execution phase.
Fixed an incorrect usage in MATCH where a variable was compared with pg_strcasecmp instead of strcmp.
Refactored some of the code using the volatile wrapper.
Verified and corrected old regression tests that were in error.
Added regression tests.