Fix ContinuousTimetable false triggering when last run ends in future #45175
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jx2lee
force-pushed
the
fix-timeteable-continuous
branch
from
336824a to
0e8de6d
Compare
uranusjr
reviewed
Dec 25, 2024
Comment on lines
144
to
+148
| start = last_automated_data_interval.end | ||
| end = timezone.coerce_datetime(timezone.utcnow()) | ||
| end = current_time | ||
|
|
||
| if start > end: # Skip scheduling if the last run ended in the future | ||
| return None |
There was a problem hiding this comment.
if last_automated_data_interval.end > current_time:
return None
start = ...
end = ...Exactly the same logic, but more readable IMO.
There was a problem hiding this comment.
Is returning None the right thing to do here? It would make this DAG not run at all in the future, even after the previous run is no longer in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #45081
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.