Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use char notation to represent a character to improve performance. #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reudismam
Copy link
Contributor

No description provided.

@asfgit
Copy link

asfgit commented Feb 16, 2018

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link

asfgit commented Feb 16, 2018

Can one of the admins verify this patch?

@jaikiran
Copy link
Member

this is ok to test

@asfgit
Copy link

asfgit commented Feb 16, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/43/

@asfgit
Copy link

asfgit commented Feb 16, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/37/

@jaikiran
Copy link
Member

Hi @reudismam, Is there some reference documentation which states that this construct performs better? My brief check of the JLS just showed a note which states that some implementations might perform better with this construct, but other than that I haven't found anything, so just curious.

@reudismam
Copy link
Contributor Author

reudismam commented Feb 16, 2018

Actually, I do not have a documentation, but there are discussions in programming community about the benefits of this change, such as this:

https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x

This edit is known to have improved performance on other projects such as Guava Project where they improve performance from 10-25%.

google/guava@8f48177

@janmaterne
Copy link
Contributor

These changes might improve performance, but do you have a testsuite with validates that? Most of the changes are done on places which are rarely invoked in a build (without having tested that ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants