-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add discovery k8s dump data interface #11111
Conversation
Test cases are also needed. |
I have not find a k8s mock apiserver like one in the test case |
is this what you are looking for? https://github.com/shreemaan-abhishek/apisix/blob/5319503293c41cf41a2caa5cb944a12d40686c83/t/kubernetes/discovery/kubernetes.t#L38-L97 |
@shreemaan-abhishek ,Thanks , I have found the method build k8s test env in workflows/kubernetes-ci.yml . |
t/kubernetes/discovery/kubernetes3.t
Outdated
@@ -332,6 +339,8 @@ POST /operators | |||
] | |||
--- more_headers | |||
Content-type: application/json | |||
--- response_body_like | |||
.*"endpoints".* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- response_body_like
.*"endpoints".*
this doesn't seem sufficient to show that the feature works fine. The verification should be more descriptive.
@hanqingwu should we add docs as well? Also, could you please show how the response body looks like? |
yes, we should add docs |
Please add docs then. |
### Memory Dump API | ||
|
||
```shell | ||
GET /v1/discovery/kubernetes/dump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GET /v1/discovery/kubernetes/dump | |
curl http://127.0.0.1:9090/v1/discovery/kubernetes/dump | jq |
Description
Fix: #11057
Checklist