Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update installation guide #11160

Closed
wants to merge 6 commits into from
Closed

docs: update installation guide #11160

wants to merge 6 commits into from

Conversation

nitishfy
Copy link

Description

Generally, when you're trying to install the apisix from the installation guide, sometimes you come across the Address Bind already in use error logs when trying to start the apisix server. This is likely caused due to the unavailability of the port. Mostly, it happens if you've installed the apisix using docker due to which the ports get equipped. Hence, when you try installing the apisix locally, you get the error logs.

This PR mentions this minor information with solution to this problem. There is a little refactoring of the docs as well. Since, it is required to install the etcd first, the installation part of etcd is moved first, followed by installation of apisix server installation.

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix for CI linting error

docs/en/latest/installation-guide.md Outdated Show resolved Hide resolved
docs/en/latest/installation-guide.md Outdated Show resolved Hide resolved
Signed-off-by: nitishfy <[email protected]>
@yzeng25 yzeng25 added the wait for update wait for the author's response in this issue/PR label Apr 23, 2024
Signed-off-by: nitishfy <[email protected]>
@nitishfy
Copy link
Author

The linter issues have been fixed now

@yzeng25 yzeng25 requested a review from kayx23 April 28, 2024 02:37
Then, you can run the following command to clone the APISIX source code from Github:

```shell
git clone --depth 1 --branch ${APISIX_VERSION} https://github.com/apache/apisix.git apisix-${APISIX_VERSION}
git clone --depth 1 --branch master https://github.com/apache/apisix.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreemaan-abhishek are these the agreed upon changes?

image

I dont have additional comments otherwise

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

@kayx23 kayx23 removed the wait for update wait for the author's response in this issue/PR label Apr 29, 2024
@@ -271,9 +271,13 @@ You can configure your APISIX deployment in two ways:
apisix start -c <path to config file>
```

APISIX will use the configurations added in this configuration file and will fall back to the default configuration if anything is not configured.
APISIX will use the configurations added in this configuration file and will fall back to the default configuration if anything is not configured. Generally, APISIX gets installed at `/usr/local/apisix/` directory, so your configuration file will be present at `/usr/local/apisix/conf/` path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
APISIX will use the configurations added in this configuration file and will fall back to the default configuration if anything is not configured. Generally, APISIX gets installed at `/usr/local/apisix/` directory, so your configuration file will be present at `/usr/local/apisix/conf/` path.
APISIX will use the configurations added in this configuration file and will fall back to the default configuration if anything is not configured. Generally, APISIX gets installed at `/usr/local/apisix/` directory, so the configuration file will be present at `/usr/local/apisix/conf/`.

APISIX will use the configurations added in this configuration file and will fall back to the default configuration if anything is not configured.
APISIX will use the configurations added in this configuration file and will fall back to the default configuration if anything is not configured. Generally, APISIX gets installed at `/usr/local/apisix/` directory, so your configuration file will be present at `/usr/local/apisix/conf/` path.

If you are unable to start APISIX and observe `Bind address already in use` in logs, it means the ports APISIX wants to use are already occupied by other running processes. Upon reviewing the use of these processes, you may decide to kill these processes or configure APISIX to use other non-conflicting ports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty basic stuff, we can remove this.


If you are unable to start APISIX and observe `Bind address already in use` in logs, it means the ports APISIX wants to use are already occupied by other running processes. Upon reviewing the use of these processes, you may decide to kill these processes or configure APISIX to use other non-conflicting ports.

Other way is to configure the default listening port to other available port on your local machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@yzeng25 yzeng25 added the wait for update wait for the author's response in this issue/PR label May 6, 2024
@kayx23
Copy link
Member

kayx23 commented May 7, 2024

Do we need this PR still? The most beneficial change here as it seems is to re-arrange etcd and APISIX installation order.

Let's re-align what needs to be done here and move this effort forward. Thanks.

@kayx23
Copy link
Member

kayx23 commented May 13, 2024

🏓

@yzeng25 yzeng25 added stale and removed wait for update wait for the author's response in this issue/PR labels May 13, 2024
@kayx23
Copy link
Member

kayx23 commented May 31, 2024

The only change beneficial here is to adjust the order of APISIX and etcd installation. This can be addressed in a separate PR. Closing this PR as it is stagnant.

@kayx23 kayx23 closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants