Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make regex-uri able to use nginx variables for Plugin[Proxy-rewrite] #11225

Closed
wants to merge 7 commits into from

Conversation

V1endr3
Copy link

@V1endr3 V1endr3 commented May 5, 2024

Description

Make regex-uri of proxy-rewrite able to use nginx variables.

Fixes #11224

Checklist

  • [v] I have explained the need for this PR and the problem it solves
  • [v] I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • [v] I have updated the documentation to reflect this change
  • [v] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Infos

  1. Tests have been done in docker env, but no new test cases added.
  2. This's my first PR for apisix & lua, if there is any bad smell of code, pls let me know. THX :D

@shreemaan-abhishek
Copy link
Contributor

@V1endr3 please describe your proposal first in #11224

@V1endr3
Copy link
Author

V1endr3 commented May 6, 2024

@V1endr3 please describe your proposal first in #11224

done, pls check it.

@shreemaan-abhishek shreemaan-abhishek marked this pull request as draft May 8, 2024 02:08
@shreemaan-abhishek
Copy link
Contributor

I have marked this PR as a draft. We can start the review once we have a consensus from the community in #11224

Copy link

github-actions bot commented Jul 8, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 8, 2024
Copy link

github-actions bot commented Aug 6, 2024

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: As a user, I want to make regex-uri able to use nginx context variables for Plugin [proxy-rewrite]
2 participants