Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support hcv namespace #11277

Merged
merged 6 commits into from
May 23, 2024
Merged

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented May 22, 2024

Description

HashiCorp Cloud and Enterprise editions support multi-tenancy based on the namespace concept. By using a specific HTTP Header, we can get the key from a specific namespace.

This makes sense, for HashiCorp Cloud it looks like namespaces are turned on by default and its default namespace is admin, which will not work when the client (APISIX) does not specify a namespace.

This PR adds namespace support on HCV (HashiCorp Vault).

Addition

In addition to this, I would suggest to rename the vault module in APISIX to hcv, based on the fact that vault itself is a neutral term that stands for some kind of component used to store keys. HashiCorp Vault is the name of that software, so it should be written hcv and not vault.

I would suggest renaming it, and in the meantime, we could add some sort of aliasing mechanism to continue to support users who use vault until APISIX 4.0, when we can remove support for the old name.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@bzp2010 bzp2010 added the enhancement New feature or request label May 22, 2024
@bzp2010 bzp2010 self-assigned this May 22, 2024
@bzp2010 bzp2010 marked this pull request as ready for review May 22, 2024 14:40
@bzp2010
Copy link
Contributor Author

bzp2010 commented May 22, 2024

I noticed that a lint error has appeared in another document, it has nothing to do with the current PR, should I fix it here?

moonming
moonming previously approved these changes May 23, 2024
@bzp2010
Copy link
Contributor Author

bzp2010 commented May 23, 2024

It looks like the code changes are fine, but the documentation changes still need to be checked by one of the main documentation maintainers:

  1. Confirm that the placement of the description is appropriate. (I didn't find any tables to document the configurations supported by HCV)
  2. where other lint errors in the documentation should be fixed

@moonming
Copy link
Member

It looks like the code changes are fine, but the documentation changes still need to be checked by one of the main documentation maintainers:

  1. Confirm that the placement of the description is appropriate. (I didn't find any tables to document the configurations supported by HCV)
  2. where other lint errors in the documentation should be fixed

@kayx23 please take a look, thx

@kayx23
Copy link
Member

kayx23 commented May 23, 2024

@bzp2010

  1. For the apache/apisix doc, the "table" you are looking for is in the Admin API reference.
  2. What lint errors? I don't see any CI checks failing.

@bzp2010 bzp2010 dismissed stale reviews from moonming and shreemaan-abhishek via 5e1dfa4 May 23, 2024 05:29
@bzp2010
Copy link
Contributor Author

bzp2010 commented May 23, 2024

Since this PR modifies the Chinese admin-api.md documentation, it also fixes the documentation lint error.

@moonming moonming merged commit 0468d78 into apache:master May 23, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants