-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support hcv namespace #11277
feat: support hcv namespace #11277
Conversation
I noticed that a lint error has appeared in another document, it has nothing to do with the current PR, should I fix it here? |
It looks like the code changes are fine, but the documentation changes still need to be checked by one of the main documentation maintainers:
|
@kayx23 please take a look, thx |
|
Since this PR modifies the Chinese |
Description
HashiCorp Cloud and Enterprise editions support multi-tenancy based on the namespace concept. By using a specific HTTP Header, we can get the key from a specific namespace.
This makes sense, for HashiCorp Cloud it looks like namespaces are turned on by default and its default namespace is admin, which will not work when the client (APISIX) does not specify a namespace.
This PR adds namespace support on HCV (HashiCorp Vault).
Addition
In addition to this, I would suggest to rename the
vault
module in APISIX tohcv
, based on the fact thatvault
itself is a neutral term that stands for some kind of component used to store keys.HashiCorp Vault
is the name of that software, so it should be writtenhcv
and notvault
.I would suggest renaming it, and in the meantime, we could add some sort of aliasing mechanism to continue to support users who use
vault
until APISIX 4.0, when we can remove support for the old name.Checklist