Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): use docker compose instead of docker-compose #11469

Merged
merged 3 commits into from
Aug 4, 2024
Merged

fix(ci): use docker compose instead of docker-compose #11469

merged 3 commits into from
Aug 4, 2024

Conversation

shreemaan-abhishek
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek commented Aug 3, 2024 •
edited
Loading

Description

Fix this bug: https://github.com/apache/apisix/actions/runs/10214310113/job/28292876764?pr=11466#step:8:13
image

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek shreemaan-abhishek marked this pull request as ready for review August 3, 2024 09:50
Gallardot
Gallardot approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzp2010 bzp2010 merged commit 564247d into apache:master Aug 4, 2024
32 checks passed
@shreemaan-abhishek shreemaan-abhishek deleted the fix/docker-compose branch August 5, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallardot Gallardot Gallardot approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreemaan-abhishek @Gallardot @juzhiyuan @bzp2010