Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links #11480

Closed
wants to merge 9 commits into from
Closed

docs: fix broken links #11480

wants to merge 9 commits into from

Conversation

Ajay-singh1
Copy link
Contributor

@Ajay-singh1 Ajay-singh1 commented Aug 6, 2024

Description

Fixes # (issue)
#11217

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@Ajay-singh1
Copy link
Contributor Author

@kayx23 I think we are good to go now.

@kayx23 kayx23 self-requested a review August 6, 2024 04:56
Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what is being fixed in this PR:

  • these changes do not create any functional differences
  • these links are not broken to begin with

Please close the PR if no other items to fix.

@Ajay-singh1
Copy link
Contributor Author

I mean the hyperlink forwards to a 404 error page not found I think this should fix that.

@Ajay-singh1
Copy link
Contributor Author

@pottekkat Can you kindly review this?

@yzeng25
Copy link
Contributor

yzeng25 commented Aug 6, 2024

Hi @Ajay-singh1 your modifications in files add-multiple-api-versions.md and manage-api-consumers.md won't fix #11217.

The current links work as expected, see Manage API Consumers - More Tutorials and Add multiple API versions - Next steps.

As stated in #11217 , the page is https://apisix.apache.org/zh/docs/apisix/tutorials/manage-api-consumers/ with zh in there. Since there is no zh-cn version of Manage API Consumers and Add multiple API versions pages, you can modify the links there and redirect to the en-us pages.

Copy link
Contributor

@yzeng25 yzeng25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change your modifications so that this pull request works as expected.

@Ajay-singh1
Copy link
Contributor Author

Ajay-singh1 commented Aug 6, 2024

Please change your modifications so that this pull request works as expected.

Yeah!Mistake thanks for the feedback I had mistakenly tried to rectify en docs will update till the end of day.

@Ajay-singh1
Copy link
Contributor Author

@yzeng25 More work needs to be done their is no chinese versions of the page so we need to wait till that time.Closing this pull request as I don't know how can I link those pages.

@Ajay-singh1 Ajay-singh1 closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants