feat(c/driver/postgresql): customize numeric conversion #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduces statement-level option `adbc.postgresql.numeric_conversion` - the option is used to tell result reader what strategy to use when converting numeric values to Arrow data; since this cannot be done 1-1, the reader has to convert to other data type - clients can use this option to specify the strategy - value can be either `to_string` or `to_double` - when not specified defaults to `to_string` - `to_string` -> numerics converted loss-less to string representation - when `to_double` -> numeric converted to double (with possible loss of precision)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adbc.postgresql.numeric_conversionto_stringorto_doubleto_stringto_string-> numerics converted loss-less to string representationto_double-> numeric converted to double (with possible loss of precision)