-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(go/adbc/driver/snowflake): workaround snowflake metadata-only limitations #1790
Conversation
@davidhcoe I've added a test that simulates the case where you running into an issue in order to confirm that it fixes the problem. But it would still be great to get you to test this with your |
I will try it either later tonight or early tomorrow at the latest. |
// the "JSON" data returned isn't valid JSON. Instead it is a list of | ||
// comma-delimited JSON lists containing every value as a string, except | ||
// for a JSON null to represent nulls. Thus we can't just use the existing | ||
// JSON parsing code in Arrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh joy
Ok, we can wait for @davidhcoe to give this a spin and then merge |
@lidavidm I emphasized on the linked snowflake issue that this is a workaround and short-term solution. If snowflake ever decides to change their JSON format (since they aren't using valid JSON) or something, they'll break us. but I can't find a better workaround / solution to this unless snowflake fixes it on their server side. |
Works great. Two thumbs up. Thank you @zeroshade. |
Yup. If it breaks, we can redirect people to Snowflake as there's only so much we can do here. |
…itations (apache#1790) Workaround to fix apache#1454 until snowflake addresses snowflakedb/gosnowflake#1110 with a better solution (hopefully by having the server actually return Arrow...)
Workaround to fix #1454 until snowflake addresses snowflakedb/gosnowflake#1110 with a better solution (hopefully by having the server actually return Arrow...)