Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use manifest ubuntu image for non-platform specific compose services #275

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

paleolimbot
Copy link
Member

Before, running docker compose run --rm docs crashed because pandoc doesn't work with docker's emulation for whatever reason. Now that the manifest image works, we can use it for those types of workflows (I left out verify because that one should pretty much always be platform-specific).

@codecov-commenter
Copy link

Codecov Report

Merging #275 (3f8d4f5) into main (3157182) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   87.19%   87.15%   -0.04%     
==========================================
  Files          66       63       -3     
  Lines       10128     9771     -357     
==========================================
- Hits         8831     8516     -315     
+ Misses       1297     1255      -42     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paleolimbot paleolimbot merged commit 6e596bd into apache:main Aug 14, 2023
3 checks passed
@paleolimbot paleolimbot deleted the duse-manifest-images branch August 15, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants