feat: Add integration testing reader for Column #325
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 87.62% 87.83% +0.21%
==========================================
Files 72 72
Lines 10906 11114 +208
==========================================
+ Hits 9556 9762 +206
- Misses 1350 1352 +2 ☔ View full report in Codecov by Sentry. |
| NANOARROW_RETURN_NOT_OK(ArrowArrayViewInitFromSchema( | ||
| array_view.get(), const_cast<ArrowSchema*>(schema), error)); |
There was a problem hiding this comment.
Perhaps ArrowArrayViewInitFromSchema should take a const ArrowSchema*?
There was a problem hiding this comment.
Definitely! #215 is the issue I was planning for that one (there are a lot of places where read-only input arguments should be marked const).
src/nanoarrow/nanoarrow_testing.hpp
Outdated
| } | ||
|
|
||
| // Build buffers | ||
| for (int i = 0; i < 3; i++) { |
There was a problem hiding this comment.
I added a define for this (NANOARROW_MAX_FIXED_BUFFERS). The ArrowArrayView and ArrowLayout define fixed-length arrays for buffer things and it's a pretty common pattern to loop over all three and switch on layout.buffer_type[i].
| @@ -0,0 +1,1508 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Did you add this file by mistake?
paleolimbot
changed the title
No description provided.