-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add integration testing reader for Column #325
feat: Add integration testing reader for Column #325
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 87.62% 87.83% +0.21%
==========================================
Files 72 72
Lines 10906 11114 +208
==========================================
+ Hits 9556 9762 +206
- Misses 1350 1352 +2 ☔ View full report in Codecov by Sentry. |
NANOARROW_RETURN_NOT_OK(ArrowArrayViewInitFromSchema( | ||
array_view.get(), const_cast<ArrowSchema*>(schema), error)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps ArrowArrayViewInitFromSchema
should take a const ArrowSchema*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! #215 is the issue I was planning for that one (there are a lot of places where read-only input arguments should be marked const
).
src/nanoarrow/nanoarrow_testing.hpp
Outdated
} | ||
|
||
// Build buffers | ||
for (int i = 0; i < 3; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the hardcoded 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a define for this (NANOARROW_MAX_FIXED_BUFFERS
). The ArrowArrayView
and ArrowLayout
define fixed-length arrays for buffer things and it's a pretty common pattern to loop over all three and switch on layout.buffer_type[i]
.
@@ -0,0 +1,1508 @@ | |||
// Licensed to the Apache Software Foundation (ASF) under one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you add this file by mistake?
No description provided.