Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure CMake linking against built/installed nanoarrow works for all components #614

Merged
merged 6 commits into from
Sep 18, 2024
Merged

fix: Ensure CMake linking against built/installed nanoarrow works for all components #614

merged 6 commits into from
Sep 18, 2024

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Sep 17, 2024 •
edited
Loading

Closes #407.

@paleolimbot paleolimbot modified the milestone: nanoarrow 0.6.0 Sep 17, 2024
@paleolimbot paleolimbot marked this pull request as ready for review September 17, 2024 21:12
assignUser
assignUser approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CMakeLists.txt Outdated Show resolved Hide resolved
examples/cmake-scenarios/CMakeLists.txt Show resolved Hide resolved
examples/cmake-scenarios/build.sh Show resolved Hide resolved
@paleolimbot paleolimbot merged commit 48168e0 into apache:main Sep 18, 2024
34 checks passed
@paleolimbot paleolimbot deleted the ci-test-component-installs branch September 19, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make extensions available as CMake components
2 participants
@paleolimbot @assignUser