Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Silence compiler warnings for parquet::file::metadata::reader #6457

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Sep 26, 2024

Rationale for this change

When compiling parquet tests with default features, several unused imports are flagged.

% cargo clippy -p parquet --all-targets -- -D warnings
    Checking parquet v53.0.0 (/Users/seidl/src/arrow-rs/parquet)
error: unused import: `std::fs::File`
   --> parquet/src/file/metadata/reader.rs:645:9
    |
645 |     use std::fs::File;
    |         ^^^^^^^^^^^^^
    |
    = note: `-D unused-imports` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_imports)]`

error: unused imports: `Read`, `SeekFrom`, and `Seek`
   --> parquet/src/file/metadata/reader.rs:648:19
    |
648 |     use std::io::{Read, Seek, SeekFrom};
    |                   ^^^^  ^^^^  ^^^^^^^^

error: unused imports: `AtomicUsize` and `Ordering`
   --> parquet/src/file/metadata/reader.rs:649:29
    |
649 |     use std::sync::atomic::{AtomicUsize, Ordering};
    |                             ^^^^^^^^^^^  ^^^^^^^^

What changes are included in this PR?

Only include the above if the "async" feature is enabled.

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label Sep 26, 2024
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it might be more maintainable to split the async tests into a separate async_tests module or something?

@alamb alamb merged commit 5804f21 into apache:master Sep 26, 2024
16 checks passed
@alamb
Copy link
Contributor

alamb commented Sep 26, 2024

Thanks @etseidl and @tustvold

@etseidl etseidl deleted the async_warnings branch September 26, 2024 20:56
etseidl added a commit to etseidl/arrow-rs that referenced this pull request Sep 26, 2024
apache#6457)

* silence compiler warnings

* add async_tests module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants