Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parquet RowSelection benchmark #6623

Merged
merged 4 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions parquet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -222,5 +222,10 @@ harness = false
name = "metadata"
harness = false

[[bench]]
name = "row_selector"
harness = false
required-features = ["arrow"]

[lib]
bench = false
89 changes: 89 additions & 0 deletions parquet/benches/row_selector.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

use arrow_array::BooleanArray;
use criterion::*;
use parquet::arrow::arrow_reader::RowSelection;
use rand::Rng;

/// Generates a random RowSelection with a specified selection ratio.
///
/// # Arguments
///
/// * `total_rows` - The total number of rows in the selection.
/// * `selection_ratio` - The ratio of rows to select (e.g., 1/3 for ~33% selection).
///
/// # Returns
///
/// * A `RowSelection` instance with randomly selected rows based on the provided ratio.
fn generate_random_row_selection(total_rows: usize, selection_ratio: f64) -> RowSelection {
let mut rng = rand::thread_rng();
let bools: Vec<bool> = (0..total_rows)
.map(|_| rng.gen_bool(selection_ratio))
.collect();
let boolean_array = BooleanArray::from(bools);
RowSelection::from_filters(&[boolean_array])
}

fn criterion_benchmark(c: &mut Criterion) {
let total_rows = 300_000;
let selection_ratio = 1.0 / 3.0;

// Generate two random RowSelections with approximately 1/3 of the rows selected.
let row_selection_a = generate_random_row_selection(total_rows, selection_ratio);
let row_selection_b = generate_random_row_selection(total_rows, selection_ratio);

// Benchmark the intersection of the two RowSelections.
c.bench_function("intersection", |b| {
b.iter(|| {
let intersection = row_selection_a.intersection(&row_selection_b);
criterion::black_box(intersection);
})
});

c.bench_function("union", |b| {
b.iter(|| {
let union = row_selection_a.union(&row_selection_b);
criterion::black_box(union);
})
});

c.bench_function("from_filters", |b| {
let mut rng = rand::thread_rng();
let bools: Vec<bool> = (0..total_rows)
.map(|_| rng.gen_bool(selection_ratio))
.collect();
let boolean_array = BooleanArray::from(bools);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like if we change generate_random_row_selection like this:

fn generate_random_row_selection(total_rows: usize, selection_ratio: f64) -> RowSelection {
    let mut rng = rand::thread_rng();
    let bools: Vec<bool> = (0..total_rows)
        .map(|_| rng.gen_bool(selection_ratio))
        .collect();
    let boolean_array = BooleanArray::from(bools);
-    RowSelection::from_filters(&[boolean_array])
}

We can save duplicated code here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get this, can you elaborate a bit more?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this:

fn generate_random_boolean_array(total_rows: usize, selection_ratio: f64) -> BooleanArray {
    let mut rng = rand::thread_rng();
    let bools: Vec<bool> = (0..total_rows)
        .map(|_| rng.gen_bool(selection_ratio))
        .collect();
    BooleanArray::from(bools)
}

// Generate two random RowSelections with approximately 1/3 of the rows selected.
let row_selection_a = RowSelection::from_filters(generate_random_boolean_array(total_rows, selection_ratio));
let row_selection_b = RowSelection::from_filters(generate_random_boolean_array(total_rows, selection_ratio));

// Benchmark the intersection of the two RowSelections.
c.bench_function("intersection", |b| {
    b.iter(|| {
        let intersection = row_selection_a.intersection(&row_selection_b);
        criterion::black_box(intersection);
    })
});

c.bench_function("union", |b| {
    b.iter(|| {
        let union = row_selection_a.union(&row_selection_b);
        criterion::black_box(union);
    })
});

c.bench_function("from_filters", |b| {
    let boolean_array = generate_random_boolean_array(total_rows, selection_ratio);
    b.iter(|| {
            let array = boolean_array.clone();
            let selection = RowSelection::from_filters(&[array]);
            criterion::black_box(selection);
    })
})

No a big issue, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, makes sense!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

b.iter(|| {
let array = boolean_array.clone();
let selection = RowSelection::from_filters(&[array]);
criterion::black_box(selection);
})
});

c.bench_function("and_then", |b| {
let selected = row_selection_a.row_count();
let sub_selection = generate_random_row_selection(selected, selection_ratio);
b.iter(|| {
let result = row_selection_a.and_then(&sub_selection);
criterion::black_box(result);
})
});
}

criterion_group!(benches, criterion_benchmark);
criterion_main!(benches);
Loading