Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter_kernel benchmark for run array #6706

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

delamarch3
Copy link
Contributor

Which issue does this PR close?

Related to #6691 and #6675

Rationale for this change

There currently aren't any filter kernel benchmarks for the run array.

What changes are included in this PR?

I've added in some benchmarks for RunArray following the examples of the others inside the filter_kernel benchmark.

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 8, 2024
@delamarch3
Copy link
Contributor Author

The results seem quite severe compared to the others:

Benchmarking filter run array (kept 1/2): Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 53.6s, or reduce sample count to 10.
filter run array (kept 1/2)
                        time:   [514.36 ms 516.31 ms 519.01 ms]
Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) high mild
  4 (4.00%) high severe

Benchmarking filter run array high selectivity (kept 1023/1024): Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 52.4s, or reduce sample count to 10.
Benchmarking filter run array high selectivity (kept 1023/1024): Collecting 100 samples in estimated 52.411 s (100 iterations
filter run array high selectivity (kept 1023/1024)
                        time:   [520.87 ms 523.03 ms 525.44 ms]
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe

Benchmarking filter run array low selectivity (kept 1/1024): Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 52.4s, or reduce sample count to 10.
filter run array low selectivity (kept 1/1024)
                        time:   [539.11 ms 547.38 ms 556.27 ms]
Found 6 outliers among 100 measurements (6.00%)
  6 (6.00%) high mild

@Dandandan
Copy link
Contributor

Thanks @delamarch3 !

@Dandandan Dandandan merged commit 28878d3 into apache:master Nov 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants