Fix Dictionary logical nulls for RunArray/UnionArray Values #6740
+50
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `DictionaryArray`, methods `logical_nulls` and `logical_null_count` would return incorrect result if the underlying values had different physical and logical nullability.
findepi
force-pushed
the
findepi/fix-dictionary-logical-nulls-5a2d83
branch
from
75faa9d
to
ef5fe4b
Compare
tustvold
approved these changes
Nov 17, 2024
tustvold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
For
DictionaryArray, methodslogical_nullsandlogical_null_countwould return incorrect result if the underlying values had different physical and logical nullability.What changes are included in this PR?
Fix
DictionaryArray.logical_nullsAre there any user-facing changes?
yes