Add configurable download method to object_store for enhanced usability #6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented and to handle concurrent downloads and efficient file writing. - Added the main function to coordinate multi-chunk downloads and writes. - Introduced support for cancellation using , enabling early termination of both downloads and writes. - Added to allow customization of concurrency, buffer size, and retry limits. These functions provide an efficient way to handle downloads from an while ensuring robust error handling and cancellation support.
…patibility with uploads. This change enhances clarity by using a more generic and versatile name for transfer-related operations. Changes made: - Updated the name in the source code. - Adjusted related documentation and comments. No functional changes were introduced beyond the refactor.
- Renamed struct TransferConfig to TransferOptions to improve code clarity and consistency. - Renamed fields in `TransferConfig`: `max_concurrent_chunks` to `concurrent_tasks`, and `chunk_queue_size` to `buffer_capacity` for clarity. - Updated references to old variables throughout the codebase. Rationale: - Improved readability and maintainability. - `<old_variable_name>` was ambiguous or inconsistent with naming conventions. No functional changes were made; this is purely a refactor for naming consistency.
…SendToChannel` formerly `SendDataError` - Renamed several error variants for better clarity and consistency. - Updated the `source` of one error to properly propagate the original cause.
- Removed redundant documentation as it's already implicit in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5277
Rationale for this change
The current
getmethod inObjectStorerequires users to handle multipart downloads and large file transfers manually, which can be complex and error-prone. This PR proposes a newdownloadmethod to streamline this process by:This change simplifies the API for users and aligns with the feature request outlined in issue #5277.
What changes are included in this PR?
downloadmethod in theobject_store::localmodule.TransferOptionsstruct for user-configurable transfer options, such as concurrency, buffer size, and retry limits.download_chunk: Downloads individual chunks of data.write_multi_chunks: Writes downloaded chunks to a local file.Are there any user-facing changes?
Yes:
downloadmethod to simplify file downloads from the object store.TransferOptionsstruct.downloadmethod.